Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: fix communication language on add #1051

Merged
merged 1 commit into from
Oct 10, 2023
Merged

library: fix communication language on add #1051

merged 1 commit into from
Oct 10, 2023

Conversation

Garfield-fr
Copy link
Contributor

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@Garfield-fr Garfield-fr self-assigned this Oct 9, 2023
@github-actions github-actions bot added f: professional ui Professional interface f: editor Concerns editor based on JSON schema AND custom editor labels Oct 9, 2023
@Garfield-fr Garfield-fr merged commit b628e68 into rero:staging Oct 10, 2023
@Garfield-fr Garfield-fr deleted the zub-library-fix branch October 10, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@lauren-d lauren-d lauren-d approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

Assignees

@Garfield-fr Garfield-fr

Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Garfield-fr @jma @zannkukai @lauren-d @PascalRepond