Upload videos #150
Open
Upload videos #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Screenshots from plugin event on(after:screenshot) (reportportal#146) 5.1.1 -> 5.1.2-SNAPSHOT Mention 5.1.1 version in changelog file 5.1.1 Update VERSION file with 5.1.1 Update changelog EPMRPP-81509 || Add mergeOptions config Fix passing mode property from config options (reportportal#142) Finish skipped tests (reportportal#141) Bump decode-uri-component from 0.2.0 to 0.2.2 (reportportal#136) Bump minimatch from 3.0.4 to 3.0.5 (reportportal#143) Bump qs from 6.5.2 to 6.5.3 (reportportal#137) Use patch version fragment 5.1.0 -> 5.1.1-SNAPSHOT # Conflicts: # lib/plugin/index.js # lib/reporter.js # test/utils.test.js
thomaswinkler
commented
Feb 24, 2023
Comment on lines
+105
to
+121
| const prepareReporterOptions = (config) => { | ||
| // copy this options from cypess config to report portal options | ||
| const passthroughOptions = { | ||
| videosFolder: config.videosFolder, | ||
| screenshotsFolder: config.screenshotsFolder, | ||
| videoUploadOnPasses: config.videoUploadOnPasses, | ||
| }; | ||
|
|
||
| return { | ||
| ...config, | ||
| reporterOptions: { | ||
| ...passthroughOptions, | ||
| ...config.reporterOptions, | ||
| }, | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
@AmsterGet I introduced a way of passing Cypress config options into reporterOptions to access selected options within the reporter. Reporter will work without any of the current passed through options, but videoUploadOnPasses is important to supported expected behavior from user perspective.
|
Is there any update on this ? It'd be great to have this in the repo. |
|
when can we expect this PR to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another approach at uploading videos to the launch log in
suiteEnd(). To support CypressvideosFolderandvideoUploadOnPassesconfig options, this options need to be passed toreporterOptionswhen the plugin is initialized. Not sure if there is another or better way, but seems to be working very well. Added tests to document the behavior.Please note, for
videoUploadOnPassesto work, the status of the root suite insuitesStackTempInfoneeds to be updated tofailedif any of it's sub suites fails.