Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): move each common module to a new page #31

Merged
merged 2 commits into from
Aug 19, 2023
Merged

feat(common): move each common module to a new page #31

merged 2 commits into from
Aug 19, 2023

Conversation

FedeIlLeone
Copy link
Member

Just like #29, this change makes navigation easier and will avoid a possible future problem with Algolia.

Includes updated types for messages common module and fixes a typo for "Item" components.

@FedeIlLeone FedeIlLeone added the enhancement New feature or request label Aug 19, 2023
asportnoy
asportnoy approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@asportnoy asportnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check every single little thing but at a high level it looks good

@FedeIlLeone FedeIlLeone merged commit 0a2fbd2 into main Aug 19, 2023
12 checks passed
@FedeIlLeone FedeIlLeone deleted the individual-common branch August 19, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asportnoy asportnoy asportnoy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FedeIlLeone @asportnoy