Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cljs compilation fixes #724

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cljs compilation fixes #724

wants to merge 2 commits into from

Conversation

pkpkpk
Copy link
Collaborator

@pkpkpk pkpkpk commented Dec 10, 2024 •
edited
Loading

SUMMARY

incremental fix for #206. restores clojurescript compilation of datahike.api, but not full functionality.

Checks

Bugfix
  • Related issues linked using fixes #number
  • Integration tests added
  • Architecture Decision Record added if design changes necessary
  • Formatting checked

ADDITIONAL INFORMATION

  • mostly superficial fixes
  • datahike.api now unrolls a top-level do form in sorted-order, instead of side-effecting evals. the sorted-order is important to cljs
  • there is a node test that tests the core namespaces compile and load ok
  • there is weird subtle behavior difference wrt vanilla & shadow cljs in the way they handle macros that is relevant to konserve, so shadow is preferred at this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pkpkpk