Add jdbcUrl as configuration parameter #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoKramer
force-pushed
the
8-jdbcUrl-missing
branch
4 times, most recently
from
6784587 to
4cb469c
Compare
next.jdbc can take urls via :jdbcUrl to configure your connection. For that to work it was necessary to make dbtype optional as configuration parameter and add jdbcUrl as optional configuration parameter. Now it is possible to pass the configuration partially as url and as key-value-pairs to configure the connection. - Closes #8 - Updated README - New CircleCI step for integrationtesting with postgresql and mariadb
TimoKramer
force-pushed
the
8-jdbcUrl-missing
branch
from
4cb469c to
81f1303
Compare
kordano
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next.jdbc can take urls via :jdbcUrl to configure your connection.
For that to work it was necessary to make dbtype optional as
configuration parameter and add jdbcUrl as optional configuration
parameter. Now it is possible to pass the configuration partially
as url and as key-value-pairs to configure the connection.