Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix age test that is based on current date #56

Merged
merged 7 commits into from
Jan 31, 2018
Merged

Fix age test that is based on current date #56

merged 7 commits into from
Jan 31, 2018

Conversation

katbusch
Copy link
Contributor

@katbusch katbusch commented Jan 30, 2018

Age test used current year, broke with new year

Fixes #55


This change is Reviewable

@katbusch katbusch assigned bnaul and unassigned bnaul Jan 30, 2018
@katbusch
Copy link
Contributor Author

Hm something else still failing, not ready yet

@coveralls
Copy link

coveralls commented Jan 30, 2018

Coverage Status

Coverage remained the same at 83.476% when pulling 2e5d59f on age-test-fix into 177c726 on master.

@katbusch
Copy link
Contributor Author

The current state of affairs is unfortunate. I had to downgrade pomegranate (#58) and skip a test (#57) to get this to work. While this is pretty bad because it means we don't really know if the list balancer works, it's probably better than the tests failing so that no new contributions in other modules can happen.

@bnaul
Copy link
Contributor

bnaul commented Jan 31, 2018

:lgtm:


Comments from Reviewable

@katbusch katbusch merged commit 19b7ca1 into master Jan 31, 2018
@katbusch katbusch deleted the age-test-fix branch January 31, 2018 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants