Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Promise.race related memory leaks in combinator functions. #66

Merged
merged 3 commits into from
Sep 2, 2020
Merged

Fix Promise.race related memory leaks in combinator functions. #66

merged 3 commits into from
Sep 2, 2020

Conversation

brainkim
Copy link
Member

@brainkim brainkim commented Sep 2, 2020 •
edited
Loading

Fixes #65

@brainkim
Copy link
Member Author

brainkim commented Sep 2, 2020

I’ve manually tested these combinators by passing an iterator of large random strings through each, but some sort of formal testing system would be nice (#11).

@brainkim brainkim merged commit a5c6628 into master Sep 2, 2020
@brainkim brainkim deleted the race-leaks branch September 2, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aggressive memory leak in Repeater.race
1 participant
@brainkim