fix(bitbucket): use last created PR in decision process #32672
+88
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraglia
changed the title
jgraglia
changed the title
jgraglia
force-pushed
the
bugfix/use_last_created_pr_in_decision
branch
from
2861256
to
2b29a48
Compare
rarkins
reviewed
Nov 22, 2024
| matchesState(p.state, state), | ||
| ); | ||
| const pr = prList | ||
| .sort((a, b) => b.number - a.number) |
There was a problem hiding this comment.
Weren't they already sorted on line 315?
There was a problem hiding this comment.
the sort at line 315 is on another branch of the code (if (includeOtherAuthors) and handle another kind of object (PrResponse vs Pr)
There was a problem hiding this comment.
I would prefer that we sort once, in one location, instead of logic being duplicated like now and also it gets repeatedly sorted every time findPr() is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When looking for an existing PR in the decision process, use the last PR created (using it's number) as it the the one with the last up to date intention of the dev team (approved,ignored, comments...)
Context
Renovate running manually as docker container, against repos on BitBucket cloud.
A non immortal PR has been created and merged.
But it was en error and the dev team, manually revert the merge commit.
Renovate still propose new PR for the same patch and the dev team can no more ignore the patch (declining subsequent PRs has no effect)
When a non immortal PR has been created multiple times, the decision process was taking the first PR returned by BitBucket cloud who happens to sort by ascending number (oldest -> newest).
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: