-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: build renovate docker images on release #26108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far
38c1c9e
to
061774d
Compare
Do you anticipate having any "race conditions" where you publish version x.y.z to npmjs and then the corresponding Docker image fails to install the same version because the npmjs CDN says it's not available? Is it already the case that every version we publish to npm will have a corresponding version on Docker? i.e. GitHub doesn't cancel duplicate workflows, and if a Docker publish fails after npm publish succeeds, is there a way to recover? Do we have a nice way to roll forward and back with this approach after merge if we find problems? |
🤔 Didn't thought about that yet.
We don't publish all versions to docker yet, because the current images are not updated that often and we only rebuild last version.
Currently the docker images are not published. I've disabled to just test the docker build on release. |
Co-authored-by: Sebastian Poxhofer <[email protected]>
🎉 This PR is included in version 37.139.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Co-authored-by: Sebastian Poxhofer <[email protected]>
Co-authored-by: Sebastian Poxhofer <[email protected]>
Co-authored-by: Sebastian Poxhofer <[email protected]>
Changes
Build our renovate images after the npm release
Context
requires those to be merged before:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: