New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buildpack): allow `undefined` `toolConstraints` for install mode #16994

Closed

viceice wants to merge 1 commit into main from viceice-patch-3

Member

viceice commented Aug 5, 2022

Changes

we need to ensure the install mode condistion is true, so i can add the preCommands to it.

Context

Support binarySource=install for all artifacts generation #13683

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository


          fix(buildpack): allow undefined toolConstraints for install mode

c9657a3

viceice requested a review from rarkins

August 5, 2022 10:01

Member Author

viceice commented Aug 5, 2022

supercessed by fix(buildpack): execute preCommads on install mode #16995

viceice closed this

viceice deleted the viceice-patch-3 branch

August 5, 2022 10:05

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet