-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): support binarySource=install #13719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not tested on a "real" repo and I don't have any reproductions to verify it against |
viceice
previously approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work
20 tasks
# Conflicts: # lib/manager/helmv3/__snapshots__/artifacts.spec.ts.snap # lib/manager/helmv3/artifacts.spec.ts # lib/manager/helmv3/artifacts.ts
viceice
approved these changes
Jan 28, 2022
auto-merge was automatically disabled
January 28, 2022 13:18
Pull Request is not mergeable
rarkins
changed the title
feat: binarySource=install for helm
feat(helm): support binarySource=install
Jan 28, 2022
🎉 This PR is included in version 31.60.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Refactors helm install in helmv3 artifacts to support binarySource=install.
Context:
Part of #13683
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: