Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v29 #12488

Merged
merged 5 commits into from
Nov 5, 2021
Merged

feat: v29 #12488

merged 5 commits into from
Nov 5, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Nov 4, 2021

Rollup of v29 features, to be rebase merged

Closes #12155, Closes #11944, Closes #11387

@HonkingGoose
Copy link
Collaborator

Do we maybe want to include breaking changes for the config into this release as well? Or do we want to save those for a later release, so I'm not holding up things now?

I'm talking specifically about:

@rarkins
Copy link
Collaborator Author

rarkins commented Nov 4, 2021

Do we maybe want to include breaking changes for the config into this release as well? Or do we want to save those for a later release, so I'm not holding up things now?

I'm talking specifically about:

Let's wait on those. I'm not so sure about the first one either.

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
lib/manager/regex/index.ts Outdated Show resolved Hide resolved
zharinov
zharinov previously approved these changes Nov 4, 2021
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems valid to me from the perspective of my GOPROXY-related PR

viceice
viceice previously approved these changes Nov 4, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the mentioned wording should be done. 🤗

@rarkins rarkins dismissed stale reviews from viceice and zharinov via 800be4d November 4, 2021 12:15
zharinov
zharinov previously approved these changes Nov 4, 2021
viceice
viceice previously approved these changes Nov 4, 2021
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
@rarkins rarkins dismissed stale reviews from viceice and zharinov via c846daf November 4, 2021 13:10
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change and then I'm done. 😄

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
HonkingGoose
HonkingGoose previously approved these changes Nov 4, 2021
fgreinacher and others added 5 commits November 5, 2021 07:56
Add configuration option `detectHostRulesFromEnv`.

BREAKING CHANGE: `hostRules` are no longer automatically derived from env variables such as `NPM_X_TOKEN`. Set `detectHostRulesFromEnv=true` in config to re-enable same functionality.
)

Allow the usage of arbitrary capture groups inside of regex manager templates and further adds refactor which this allows.

BREAKING_CHANGE
Only regex managers using the combination matchStringStrategy are affected of this change!
Currently capture groups which are empty but still match the regex are ignored.
This is no longer the case!
Subsequent matchGroups will now overwrite previous ones, even if the later one is empty.
Current implementation tries to use GOPROXY and falls back to Renovate fetching mechanism if no releases found.

The new one is switches to GOPROXY implementaiton when environment variable is set and doesn't fallback.
However, when direct keyword is used, it will use Renovate-native mechanism that fetches directly from GitHub, etc.
When off keyword is encountered or no URLs left, we're done with no releases (i.e. no fallback to Renovate-native mechanism).

BREAKING CHANGE: Go modules lookups will now no longer fallback to Renovate native lookups if GOPROXY is configured and without "direct" explicitly configured.
Flips platformAutomerge default to `false`.

BREAKING CHANGE: Platform automerge is no longer enabled by default.
@rarkins rarkins merged commit 4eadba6 into main Nov 5, 2021
@rarkins rarkins deleted the v29 branch November 5, 2021 07:10
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable inferring credentials from environment variables Validate regex manager combination strategy
7 participants