Remove alpha channel from transparent images #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, it indeed fixes the issue, and avoids a crash when running against the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the alpha channel from transparent images. Transparency is not supported by blurhash, see woltapp/blurhash#100.
The pixels array should have chunks of 3 bytes per pixel, but images which have an alpha channel (e.g. png files) have 4 bytes per pixel. This is also verified in Gargron/blurhash@3d8a39c since version 0.1.8 which was released last week.
fixes
This PR fixes #12.
possible improvements
The
flattenmethod used here takes an optional argumentbackground:. Adding this and making it configurable for users of this plugin would allow configuring a different background color than the default (white).alternatives
Users of this plugin might alternatively consider migrating to thumbhash if real transparency is needed.