Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Cleanup #1

wants to merge 10 commits into from

Conversation

renatodeleao
Copy link
Owner

@renatodeleao renatodeleao commented Jun 19, 2019

  • Fixing immediate errors on some methods
  • KeepOpen prop
  • Small enhancements and mostly code cleanup

Todos:

  • Documentation of the new keepOpen prop

- Tabs vs spaces
- Prettier
other parts of code depden on value that is serialized. This could have side-effects.
Atm some of our methods depends on this state to work, like selecting options. So dispite it could be visually visible since it's rendereless thing, the functionality would not work.
since other function require the serialized object to not throw undefined object props errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant