Switch from Omd to Cmarkit #932
Open
+262
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been stuck on Omd 1 for a long time. While we could upgrade to the newer Omd version, it does not seem very actively maintained, and since we'd have to rewrite anyway it seems like a good opportunity to switch to the newer Cmarkit library which has some nice additional features. A best effort attempt has been made to preserve `sail --doc` and `sail --latex` features, but there may be small changes in functionality. This does require increasing our minimum OCaml version to 4.14+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been stuck on Omd 1 for a long time. While we could upgrade to the newer Omd version, it does not seem very actively maintained, and since we'd have to rewrite all our code using it anyway it seems like a good opportunity to switch to the newer Cmarkit library which has some nice additional features and sticks closely to the CommonMark spec.
A best effort attempt has been made to preserve
sail --docandsail --latexfeatures, but there may be small changes in functionality and appearance.This does require increasing our minimum OCaml version to 4.14+, but that might be overdue at this point (and we might also just want to require OCaml 5 soon anyway).