don't pass trailing dot to local resolver, add test coverage

src/Entities/Hostname.php

@@ -41,6 +41,11 @@ public function getHostName(): string
         return $this->hostname;
     }
 
+    public function getHostnameWithoutTrailingDot(): string
+    {
+        return substr($this->hostname, 0, -1);
+    }
+
     public function isPunycoded(): bool
     {
         return $this->toUTF8() !== $this->hostname;

src/Resolvers/LocalSystem.php

@@ -37,7 +37,11 @@ public function getHostnameByAddress(string $IPAddress): Hostname
 
     protected function doQuery(Hostname $hostname, DNSRecordType $type): DNSRecordCollection
     {
-        $results = $this->systemDNS->getRecord($hostname, $this->mapper->getTypeCodeFromType($type));
+        $results = $this->systemDNS->getRecord(
+            $hostname->getHostnameWithoutTrailingDot(), // dns_get_record doesn't like trailing dot as much!
+            $this->mapper->getTypeCodeFromType($type)
+        );
+
         $collection = new DNSRecordCollection();
 
         foreach ($results as $result) {

tests/Unit/Entities/DNSRecordTest.php

@@ -86,6 +86,7 @@ public function isSerializable()
         $this->assertSerializable($this->DNSARecord);
 
         $this->assertEquals(unserialize(serialize($this->DNSARecord)), $this->DNSARecord);
+        $this->assertEquals(unserialize(serialize($this->DNSTXTRecord)), $this->DNSTXTRecord);
     }
 
     /**

tests/Unit/Entities/HostnameTest.php

@@ -25,6 +25,7 @@ public function hasBasicGettersAndIsStringy()
     {
         $this->assertSame('facebook.com.', (string)$this->hostname);
         $this->assertSame('facebook.com.', $this->hostname->getHostName());
+        $this->assertSame('facebook.com', $this->hostname->getHostnameWithoutTrailingDot());
     }
 
     /**

tests/Unit/Resolvers/LocalSystemTest.php

@@ -47,7 +47,7 @@ public function hasOrDoesNotHaveRecord()
 
         $this->dnsClient->expects($this->exactly(2))
             ->method('getRecord')
-            ->with('facebook.com.', 1)
+            ->with('facebook.com', 1)
             ->willReturnOnConsecutiveCalls(
                 self::getEmptyResponse(),
                 self::buildResponse('A')
@@ -80,7 +80,7 @@ public function getsRecords(string $method, Hostname $hostname, DNSRecordType $t
     {
         $this->dnsClient->expects($this->once())
             ->method('getRecord')
-            ->with((string) $hostname, $this->localSystemMapper->getTypeCodeFromType($type))
+            ->with($hostname->getHostnameWithoutTrailingDot(), $this->localSystemMapper->getTypeCodeFromType($type))
             ->willReturn($response);
 
         $actual = $this->localSystem->{$method}($hostname, $type);