-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix h2 peak in buildings #1654
base: develop
Are you sure you want to change the base?
Fix h2 peak in buildings #1654
Conversation
…ation are passed by the config (prelim solution)
…d, adjust the config accordingly.
@Renato-Rodrigues @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q @robertpietzcker @LaviniaBaumstark : This PR covers the change we discussed in Mattermost some weeks ago. I am very happy to hear your comments and remarks here now. |
config/default.cfg
Outdated
@@ -30,7 +30,7 @@ cfg$extramappings_historic <- "" | |||
cfg$inputRevision <- "6.70" | |||
|
|||
#### Current CES parameter and GDX revision (commit hash) #### | |||
cfg$CESandGDXversion <- "cdddb54b54a8586b4fef00eb60a3be6cfa23ca55" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for which scenarios did you run the calibration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the calibration for H12, EU21 and PBS and I'm planning to redo this once I've merged the trunk. Should I test the calibration with further scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully, we will have pbs as default soon and then I will anyway run new calibrations for all other scenarios. I think, for now SSP2EU is enough
config/gdx-files/files
Outdated
@@ -9,5 +9,6 @@ indu_subsectors-buil_simple-tran_edge_esm-POP_pop_SDP_EI-GDP_gdp_SDP_EI-En_gdp_S | |||
indu_subsectors-buil_simple-tran_edge_esm-POP_pop_SSP5-GDP_gdp_SSP5-En_gdp_SSP5-Kap_debt_limit-Reg_62eff8f7.gdx | |||
indu_subsectors-buil_simple-tran_edge_esm-POP_pop_SSP2EU-GDP_gdp_SSP2EU-En_gdp_SSP2EU-Kap_debt_limit-Reg_2b1450bc.gdx | |||
indu_subsectorspbs-buil_simple-tran_edge_esm-POP_pop_SSP2EU-GDP_gdp_SSP2EU-En_gdp_SSP2EU-Kap_debt_limit-Reg_62eff8f7.gdx | |||
indu_subsectors-buil_simple-tran_edge_esm-POP_pop_SSP2EU-GDP_gdp_SSP2EU-En_gdp_SSP2EU-Kap_debt_limit-H2zero-Reg_62eff8f7.gdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you adding a new calibration file? The aim is that this will be the new default, right? This is only a temporal solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be deleted. I already took a note (somewhere) that I should remember to delete all this. Thanks for reminding me again.
$ifthen.CES_calibration "%CES_parameters%" == "calibrate" | ||
v36_H2share.up(t,regi) = cm_build_H2costDecayStart; | ||
v36_costAddH2LowPen.fx(t,regi) = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is v36_costAddH2LowPen still needed or coud it be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still needed for non-calibration runs. And in the current implementation it needs to be set to zero for a calibration run to make sure that no Phase-In costs are included.
Purpose of this PR
Remind has displayed unusual behavior for hydrogen in buildings, using quite significant amounts of hydrogen for a very limited time period only:
This has been addressed in PR #1303 by ruling out hydrogen in buildings completely. The current PR solves the issue of H2-spikes in buildings by a more comprehensive approach:
The final item on this list can be argued for as follows:
In the calibration, we aim to set the balance between fossil gas and hydrogen in the standard state, not the state during Phase-In. The Phase-In costs serve to make usage of hydrogen more difficult. If we already include the Phase-In costs during calibration, this barrier is already overcome by higher efficiencies determined in the calibration. Hence Remind is calibrated to be at the point where it only just does not use hydrogen, even with the barrier costs.
The previous behavior can be obtained by setting c_H2InBuildOnlyAfter to 2025 again.
I still need to merge the trunk and delete some superfluous files etc., therefore this is still a draft.
Type of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):
Test runs are here:
/p/tmp/ricardar/remind/adjH2-for-merge/remind/output
CompScens are here:
/p/tmp/ricardar/remind/adjH2-for-merge/remind/compScen-2024-03-13_15.59.31-H12.pdf
/p/tmp/ricardar/remind/adjH2-for-merge/remind/compScen-EU21-noBase-2024-04-02_10.30.16-EU27.pdf
/p/tmp/ricardar/remind/adjH2-for-merge/remind/compScen-_PBS-2024-03-17_21.18.28-H12.pdf
Comparison of results (what changes by this PR?):
(to be added)