Extend IsProd with divert
#4
Conversation
|
This comment ensures that the correct Slack channel is notified after the team/project label See this comment for details. |
| func IsProd() bool { | ||
| return Env == "production" || Env == "prod" | ||
| return Env == "production" || Env == "prod" || Env == "divert" |
There was a problem hiding this comment.
Wow. I was not even aware that we need a whole package to deal just with one environment variable.
I think the idea long time ago was to have smth like https://github.com/bkeepers/dotenv .
The downside of this pr is that is adds some custom Env specific for Remerge - divert - but it is a public repo actually =)
I think we need to make it private and in the long term maybe shut it down completely - we do not use it as intended.
WDYT @itszootime ?
There was a problem hiding this comment.
If there will be no response - merge it, I have approved it.
I think it is not critical anyway
The change is to extend
productionenvironment withdivertvalue.No
IsDivertintroduced to keep a behavior for diverts the same as for production builds.Ticket: https://remerge.atlassian.net/browse/CORE-755