MSG_WriteBitAngle: Cap the precision check from 32 to 22 to avoid ove…

…rflow issues when representing angles with more than 22 bits because the multiply by 'shift' may result in overflow
rehlds · Jan 25, 2024 · 666d8c8 · 666d8c8
1 parent 9b0dbe8
commit 666d8c8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/rehlds/engine/common.cpp b/rehlds/engine/common.cpp
@@ -586,9 +586,9 @@ void MSG_WriteBitData(void *src, int length)
 
 void MSG_WriteBitAngle(float fAngle, int numbits)
 {
-	if (numbits >= 32)
+	if (numbits > 22)
 	{
-		Sys_Error("%s: Can't write bit angle with 32 bits precision\n", __func__);
+		Sys_Error("%s: Can't write bit angle with 22 bits precision\n", __func__);
 	}
 
 	uint32 shift = (1 << numbits);