Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Workflow Refactor and Fixes #1016

Merged

Conversation

SergeyShorokhov
Copy link
Member

@SergeyShorokhov SergeyShorokhov commented Sep 23, 2024

CI Workflow Refactor and Fixes

This pull request addresses a critical issue with the CI pipeline, improving compatibility with Node.js versions and standardizing CI processes across repositories.

Fixes

  • Resolved Node.js Compatibility Issue
    • Updated actions and dependencies to work with newer *-latest OS versions, addressing failures caused by Node.js version incompatibility with older actions. Older container configurations for build and demo test steps have been updated to align with this change.

Changes

  • Action Upgrades

    • Upgraded upload-artifact and download-artifact actions to version 4 for improved artifact handling.
  • Testing and Demo Configuration

    • Migrated to ubuntu-latest and updated the container image to rehldsorg/testdemos:latest.
    • Simplified demo test execution with a matrix strategy, using runTest.sh to streamline test runs.
  • Linux Dependency Standardization

    • Consolidated the installation of required libraries to reduce redundancy in dependency handling.
  • Standardized CI Approach Across Repositories

    • Aligned the CI structure with similar repositories (rehlds, regamedll) for consistent workflow management.

Impact

These fixes and changes enhance CI reliability, maintainability, and streamline artifact management across related repositories.

Refer:

@SergeyShorokhov SergeyShorokhov added Type: 🛠️ maintenance Tasks related to technical debt, infrastructure upkeep. Type: 🛑 dependency Routine tasks, maintenance, or non-user-facing changes. labels Sep 23, 2024
@SergeyShorokhov SergeyShorokhov marked this pull request as draft September 23, 2024 13:55
@SergeyShorokhov SergeyShorokhov marked this pull request as ready for review October 15, 2024 10:18
@SergeyShorokhov SergeyShorokhov changed the title New docker image testdemos CI Workflow Refactor and Fixes Oct 29, 2024
@SergeyShorokhov SergeyShorokhov merged commit 7738142 into rehlds:master Oct 29, 2024
4 checks passed
@SergeyShorokhov SergeyShorokhov deleted the fix/testdemos-new-image branch October 29, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: 🛑 dependency Routine tasks, maintenance, or non-user-facing changes. Type: 🛠️ maintenance Tasks related to technical debt, infrastructure upkeep.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants