Skip to content

Commit

Permalink
fix: remove use of virtual in node-gyp multistage (nodejs#1034)
Browse files Browse the repository at this point in the history
fix: remove use of virtual in node-gyp multistage
  • Loading branch information
SimenB authored Jul 8, 2019
2 parents b1be313 + 52f1580 commit cf8c6bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/BestPractices.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ And Here's a multistage build example
FROM node:alpine as builder

## Install build toolchain, install node deps and compile native add-ons
RUN apk add --no-cache --virtual .gyp python make g++
RUN apk add --no-cache python make g++
RUN npm install [ your npm dependencies here ]

FROM node:alpine as app
Expand Down

0 comments on commit cf8c6bb

Please sign in to comment.