Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend character validations for model,fields,tags and measurement names , fix #392 #402

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

toni-moreno
Copy link

Hi @regel here the PR , I've removed dotted_key as in standar key the dot is included. Aso added test key as suggested last week.
Currently tested and working with this image tonimoreno/loudml:1.6.2

as you can see here.

> show-model MY_MODEL
- settings:
    bucket_interval: 10m
    default_bucket: XXXXXXX
    features:
    - anomaly_type: low_high
      field: value
      io: io
      match_all:
      - tag: metric_id
        value: '2123123'
      measurement: traffic.rxt_et-1/0/0 <---------------------------HERE OK!
      metric: mean
      name: mean_value
    grace_period: 0
    interval: 60s
    max_evals: 20
    max_threshold: 70
    min_threshold: 50
    name: MY_MODEL
    offset: 1h
    run:
      flag_abnormal_data: true
      output_bucket: XXXXXXXXXXXXXXXXXX
      save_output_data: true
    seasonality:
      daytime: true
      weekday: true
    span: 256
    type: donut

@toni-moreno toni-moreno force-pushed the extend_character_key_validations branch from f199868 to 351e721 Compare November 7, 2020 10:40
@toni-moreno toni-moreno force-pushed the extend_character_key_validations branch from 351e721 to a807755 Compare November 7, 2020 10:51
@toni-moreno
Copy link
Author

Hello @regel , I would like to know about the status of this PR. it seems ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant