check create_database config option prior to force create annotation database #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toni-moreno
changed the title
|
Hello @regel Would be great if you could review and merge this PR. do you need anything more to do before to merge? |
|
Hi Toni, thanks so much! I will review and merge on Saturday. |
|
Hello @regel. I would like review the status for some PR's. What about this one? |
|
Hi @regel , how about this PR? We would use loudml in Enterprise-Environment and not allowed to give Admin-Rights to the loudml-user. Could you merge this PR near time? |
|
Hello @regel , we are currently testing loudml in our Enterprise-Environment and have encountered the same problem. Giving the loudml user admin rights is unfortunately not an option in our production environment. Are there any plans to work on this PR in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit fix #122, and enables non admin READ/WRITE users access to the database.