redis hash for StateManagerRedis #4459
Open
+210
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci failure is the typical dynamic routes flakyness |
remove oxbow code now that REDIS_URL must be a real redis url
Continue to support redis < 7.2 Instead of updating individual substate expiration, in older versions of redis any update to any substate will cause the entire state expiration to be refreshed, which is better than not supporting older redis versions.
redis-py 5.1.0 adds support for the .hexpire() command
|
@benedikt-bartscher i really like this one 👍 |
|
@masenf thanks for the feedback and compability improvements you have pushed. I really appreciate it. We are already using this since some weeks and did not experience any issues. Will update our fork to the latest changes and keep you posted if everything still works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drastically reduces the amount of redis calls for apps with many states
Keeps all states of a session in one redis hashmap instead of separate redis keys