Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX-66] rpk: save crash information in rpk debug bundle #24778

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

r-vasquez
Copy link
Contributor

This PR adds the capability to rpk to collect both the startup_log file and the crash_reports directory if it's present in the data directory, otherwise it will skip the step and move forward with the bundle collection.

Fixes UX-66

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

Features

  • rpk debug bundle will now collect the startup_log file and crash_reports directory if they are present in the data directory.

If not we just warn that we skipped the collection
but the bundle will still be completed
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 11, 2025

Retry command for Build#60613

please wait until all jobs are finished before running the slash command



/ci-repeat 1
tests/rptest/tests/rbac_test.py::RolePersistenceTest.test_role_survives_restart
tests/rptest/tests/rpk_debug_bundle_test.py::RpkDebugBundleTest.test_debug_bundle

@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#60613
test_id test_kind job_url test_status passed
idempotency_tests_rpunit.idempotency_tests_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60613#019452c1-83ad-4258-888f-692d80f6ace9 FLAKY 1/2
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60613#01945303-8f62-4cc2-85df-081af4a673ab FLAKY 4/6
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60613#01945308-4865-47db-8518-d44bc9005cf2 FLAKY 4/6
rptest.tests.rbac_test.RolePersistenceTest.test_role_survives_restart ducktape https://buildkite.com/redpanda/redpanda/builds/60613#01945303-8f5e-41f4-ad7c-fda281be437c FAIL 0/1
rptest.tests.rpk_debug_bundle_test.RpkDebugBundleTest.test_debug_bundle ducktape https://buildkite.com/redpanda/redpanda/builds/60613#01945303-8f61-4544-94fc-7a9d2ea84ded FAIL 0/1
rptest.tests.rpk_debug_bundle_test.RpkDebugBundleTest.test_debug_bundle ducktape https://buildkite.com/redpanda/redpanda/builds/60613#01945308-4864-44ca-ab54-63d72cccb8b5 FAIL 0/1

pgellert
pgellert previously approved these changes Jan 13, 2025
Copy link
Contributor

@pgellert pgellert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've tested this with crash reports generated from my POC branch and it works well.

Same as startup_log, we will only collect the
directory if it's present
@r-vasquez
Copy link
Contributor Author

Force Push:

  • Add expected errors to the ducktape debug bundle test

@r-vasquez r-vasquez requested a review from pgellert January 14, 2025 15:51
@r-vasquez r-vasquez merged commit 964cc35 into redpanda-data:dev Jan 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants