-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX-66] rpk: save crash information in rpk debug bundle #24778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not we just warn that we skipped the collection but the bundle will still be completed
r-vasquez
requested review from
twmb,
gene-redpanda and
Deflaimun
as code owners
January 11, 2025 00:23
Retry command for Build#60613please wait until all jobs are finished before running the slash command
|
CI test resultstest results on build#60613
|
pgellert
previously approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've tested this with crash reports generated from my POC branch and it works well.
Same as startup_log, we will only collect the directory if it's present
r-vasquez
force-pushed
the
save-crash-bundle
branch
from
January 14, 2025 06:56
d05dc66
to
4d54c8a
Compare
|
pgellert
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to rpk to collect both the
startup_log
file and thecrash_reports
directory if it's present in the data directory, otherwise it will skip the step and move forward with the bundle collection.Fixes UX-66
Backports Required
Release Notes
Features
startup_log
file andcrash_reports
directory if they are present in the data directory.