Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.3.x] [UX-53] rpk: add well-known protobuf types to rpk #24699

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[v24.3.x] [UX-53] rpk: add well-known protobuf types to rpk #24699

merged 1 commit into from
Jan 7, 2025

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #24480

@r-vasquez @vbotbuildovich
rpk: add well-known protobuf types to rpk
aa5f7d0 
This is the same set of well-known types that
both Redpanda and Redpanda Console already support

This allows users to use the whole suite and
encode/decode using these well-known types.

One rpk unit tests verify that the embedded types
are the same as the ones in the Redpanda repo,
hence the need to trigger rpk tests on changes
in pandaproxy/schema_registry/protobuf

(cherry picked from commit 05cd928)
@vbotbuildovich vbotbuildovich requested a review from twmb as a code owner January 6, 2025 23:35
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Jan 6, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 6, 2025
@vbotbuildovich vbotbuildovich requested review from Deflaimun and a team as code owners January 6, 2025 23:35
@vbotbuildovich vbotbuildovich requested review from gousteris and removed request for a team January 6, 2025 23:35
@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#60326
test_id test_kind job_url test_status passed
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.S3.retention_type=retention.bytes ducktape https://buildkite.com/redpanda/redpanda/builds/60326#01943e68-5029-4e37-a45c-3799257835d9 FLAKY 5/6

@r-vasquez r-vasquez merged commit b895231 into redpanda-data:v24.3.x Jan 7, 2025
26 checks passed
@piyushredpanda piyushredpanda modified the milestones: v24.3.x-next, v24.3.3 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

@gousteris gousteris Awaiting requested review from gousteris gousteris is a code owner automatically assigned from redpanda-data/devprod

Assignees
No one assigned
Labels
area/build area/redpanda area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@vbotbuildovich @r-vasquez @piyushredpanda