Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-2701 Quotas: remove client quota cluster configs #24697

Merged
merged 3 commits into from
Jan 9, 2025
Merged

CORE-2701 Quotas: remove client quota cluster configs #24697

merged 3 commits into from
Jan 9, 2025

Conversation

pgellert
Copy link
Contributor

@pgellert pgellert commented Jan 6, 2025 •
edited
Loading

As promised since the v24.2 release, with v25.1, the cluster-configuration-based client quotas are removed:

Fixes https://redpandadata.atlassian.net/browse/CORE-8711

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

Features

@pgellert pgellert requested a review from a team January 6, 2025 15:45
@pgellert pgellert self-assigned this Jan 6, 2025
@pgellert pgellert requested review from IoannisRP and removed request for a team January 6, 2025 15:45
@pgellert
kafka: deprecate quota configs
11019dd 
As promised in the v24.2 release, with v25.1 the cluter-config-based
approach of configuring client quotas is removed.
@pgellert
k/server/tests: delete scale_to_smp_count()
81c0a99 
This was a helper for the cluster-config-based tests. It is no longer
relevant and so can be removed to simplify.
@pgellert
k/server/tests: renumber quota_translator_priority_order
572132d 
Renumber the values used in `quota_translator_priority_order` to make
the test simpler to reason about now that the config-based quotas have
been removed.
@pgellert pgellert force-pushed the quotas/deprecate-configs branch from dee70ef to 572132d Compare January 9, 2025 10:26
@pgellert pgellert marked this pull request as ready for review January 9, 2025 10:26
@pgellert pgellert requested a review from a team as a code owner January 9, 2025 10:26
@pgellert
Copy link
Contributor Author

pgellert commented Jan 9, 2025

This is ready for review now that #24696 has been merged. (force-push: rebase)

IoannisRP
IoannisRP reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@IoannisRP IoannisRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

michael-redpanda
michael-redpanda approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@michael-redpanda michael-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love negative sloc reviews

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 9, 2025 •
edited
Loading

CI test results

test results on build#60489
test_id test_kind job_url test_status passed
idempotency_tests_rpunit.idempotency_tests_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60489#01944a9b-720b-4fcb-9691-74b0f9169108 FLAKY 1/2
rm_stm_tests_rpunit.rm_stm_tests_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60489#01944a9b-720c-4b86-b49f-10255bce9c44 FLAKY 1/2
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60489#01944ae4-265f-4c39-9248-4e9504a33cbd FLAKY 2/6
test results on build#60506
test_id test_kind job_url test_status passed
rm_stm_tests_rpunit.rm_stm_tests_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60506#01944b93-40ea-4cf2-a8cc-66895e258351 FLAKY 1/2
rptest.tests.archival_test.ArchivalTest.test_single_partition_leadership_transfer.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/60506#01944bf0-91e8-45bd-913c-9e73deb326d5 FAIL 0/1
rptest.tests.datalake.simple_connect_test.RedpandaConnectIcebergTest.test_translating_avro_serialized_records.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/60506#01944bf0-91e9-4549-a31d-e00243042763 FLAKY 5/6
rptest.tests.partition_reassignments_test.PartitionReassignmentsTest.test_reassignments_kafka_cli ducktape https://buildkite.com/redpanda/redpanda/builds/60506#01944bf0-91e9-4549-a31d-e00243042763 FLAKY 5/6

@pgellert
Copy link
Contributor Author

pgellert commented Jan 9, 2025

/ci-repeat 1

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#60506

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/archival_test.py::ArchivalTest.test_single_partition_leadership_transfer@{"cloud_storage_type":1}

@pgellert pgellert merged commit 60a516f into redpanda-data:dev Jan 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IoannisRP IoannisRP IoannisRP left review comments

@michael-redpanda michael-redpanda michael-redpanda approved these changes

Assignees

@pgellert pgellert

Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgellert @vbotbuildovich @michael-redpanda @IoannisRP