rpk bundle: Fix race condition in SASL credential redaction #24675
+38
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a bug where SASL credentials stored only in the redpanda.yaml could be redacted before being used for authentication. If the credentials were not provided elsewhere (e.g. via environment variables or flags), the redacted value would be used, leading to authentication errors due to invalid credentials.
r-vasquez
requested review from
twmb,
gene-redpanda and
Deflaimun
as code owners
|
/backport v24.3.x |
|
/backport v24.2.x |
|
/backport v24.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where SASL credentials stored only in the redpanda.yaml could be redacted before being used for authentication in the debug bundle.
If the credentials were not provided elsewhere (e.g. via environment variables or flags), the redacted value would be used, leading to authentication errors due to invalid credentials.
Please note that this is an old mechanism for storing the credentials and it only affected debug bundle creation, this will not happen if profiles (or flags/env vars) are being used.
Backports Required
Release Notes