tests/datalake: deflake partition_movement_test #24661
Open
+52
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-repeat 1 |
This fixes a subtle deadlock where positions are not updated before the memory fills up and query thread cannot make progress without correct fetch positions. Removed timer based logic that periodically updates positions, it will be further refined in the next commits.
Two main optimizations here - Batch enough messages so each SQL query spans bigger range of offsets (reduces # of queries) - Avoids updating fetch positions too often, since the loop sweeps through every partition, debouncing it until enough messages are batched.
|
/ci-repeat 1 |
|
/ci-repeat 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a subtle deadlock where positions are not updated before the memory fills up and query thread cannot make progress without correct fetch positions, so nothing drains the memory semaphore.
Optimizes verification process to batch enough messages and thus reducing # of queries and also lowering the frequency of updating fetch positions.
Fixes https://redpandadata.atlassian.net/browse/CORE-8581
Backports Required
Release Notes