Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ducktape: Verify using consumer groups in the MPT #24656

Merged
merged 1 commit into from
Jan 6, 2025
Merged

ducktape: Verify using consumer groups in the MPT #24656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tests/rptest/scale_tests/many_partitions_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from rptest.scale_tests.topic_scale_profiles import TopicScaleProfileManager
from rptest.services.rpk_consumer import RpkConsumer
from rptest.services.redpanda import RESTART_LOG_ALLOW_LIST, LoggingConfig, MetricsEndpoint
from rptest.services.kgo_verifier_services import KgoVerifierProducer, KgoVerifierSeqConsumer, KgoVerifierRandomConsumer
from rptest.services.kgo_verifier_services import KgoVerifierProducer, KgoVerifierConsumerGroupConsumer, KgoVerifierRandomConsumer
from rptest.services.kgo_repeater_service import KgoRepeaterService, repeater_traffic
from rptest.services.openmessaging_benchmark import OpenMessagingBenchmark
from rptest.services.openmessaging_benchmark_configs import OMBSampleConfigurations
Expand Down Expand Up @@ -612,20 +612,21 @@ def _write_and_random_read(self, scale: ScaleParameters, topic_names):
# minutes during these events.
expect_transmit_time += 600

seq_consumer = KgoVerifierSeqConsumer(
verifier = KgoVerifierConsumerGroupConsumer(
self.test_context,
self.redpanda,
target_topic,
0,
readers=math.ceil(scale.partition_limit / 5000),
Copy link
Member

@travisdowns travisdowns Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this result in 5000 partitions per reader still? I thought that was way too many per the cover letter, i.e., we would still be in "(think 1k+ partitions per request)" territory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It results in 5000 / 6 (broker count) per reader so not entirely 1k+ but still high. As mentioned in the cover letter I still want to keep this around a little bit but just not extreme enough to hit the edge case.

max_msgs=max_msgs,
nodes=[self.preallocated_nodes[2]])
seq_consumer.start(clean=False)
verifier.start(clean=False)

seq_consumer.wait(timeout_sec=expect_transmit_time)
assert seq_consumer.consumer_status.validator.invalid_reads == 0
verifier.wait(timeout_sec=expect_transmit_time)
assert verifier.consumer_status.validator.invalid_reads == 0
if not scale.tiered_storage_enabled:
assert seq_consumer.consumer_status.validator.valid_reads >= fast_producer.produce_status.acked + msg_count_per_topic, \
f"{seq_consumer.consumer_status.validator.valid_reads} >= {fast_producer.produce_status.acked} + {msg_count_per_topic}"
assert verifier.consumer_status.validator.valid_reads >= fast_producer.produce_status.acked + msg_count_per_topic, \
f"{verifier.consumer_status.validator.valid_reads} >= {fast_producer.produce_status.acked} + {msg_count_per_topic}"

self.free_preallocated_nodes()

Expand Down
Loading