rptest/datalake: test metadata interoperability with 3rd party system #24643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemKauf
reviewed
Dec 23, 2024
nvartolomei
force-pushed
the
nv/iceberg-3rdparty-rewrite
branch
2 times, most recently
from
6f1f148 to
6e607dd
Compare
Retry command for Build#60089please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#60089
test results on build#60100
test results on build#60178
|
nvartolomei
force-pushed
the
nv/iceberg-3rdparty-rewrite
branch
2 times, most recently
from
1292bb1 to
6e1e926
Compare
andrwng
reviewed
Dec 24, 2024
Comment on lines
+155
to
+169
| def run_sample_maintenance_task(self, namespace, table) -> None: | ||
| # Metadata query | ||
| # https://iceberg.apache.org/docs/1.6.1/spark-queries/#files | ||
| initial_parquet_files = self.run_query_fetch_one( | ||
| f"SELECT count(*) FROM {namespace}.{table}.files")[0] | ||
|
|
||
| # Want at least 2 files to be able to assert that optimization did something. | ||
| assert initial_parquet_files >= 2, f"Expecting at least 2 files, got {initial_parquet_files}" | ||
|
|
||
| # Spark Procedures provided by Iceberg SQL Extensions | ||
| # https://iceberg.apache.org/docs/1.6.1/spark-procedures/#rewrite_data_files | ||
| self.run_query_fetch_one( | ||
| f"CALL `redpanda-iceberg-catalog`.system.rewrite_data_files(\"{namespace}.{table}\")" | ||
| ) | ||
|
|
||
| optimized_parquet_files = self.run_query_fetch_one( | ||
| f"SELECT count(*) FROM {namespace}.{table}.files")[0] | ||
| assert optimized_parquet_files < initial_parquet_files, f"Expecting fewer files after optimize, got {optimized_parquet_files}" |
There was a problem hiding this comment.
IMO these service classes should only hold operations, not validations. To that end, can we split this into some count_parquet_files() and optimize_parquet_files()? There are many different kinds of maintenance https://iceberg.apache.org/docs/1.5.1/maintenance/ and it'll be much easier to reuse if we're more descriptive and have smaller, tighter primitives.
There was a problem hiding this comment.
@andrwng I see what you mean but here I wanted to give more freedom to these maintenance tasks implementation, i.e. it might as well be a metadata only maintenance. I documented the expectations in the code doc
optimize_parquet_files and count_parquet_files would work for the 2 engines we have now, do you reckon all of them expose the same primitives so that we could have a single test for all of them?
Will be used for testing interoperability with 3rd party vendors.
nvartolomei
force-pushed
the
nv/iceberg-3rdparty-rewrite
branch
2 times, most recently
from
4b21a17 to
92f74aa
Compare
Retry command for Build#60178please wait until all jobs are finished before running the slash command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes