[v24.3.x] storage: check for may_have_tombstones in self_compact_segment (manual backport)
#24500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segments that may have tombstone records in them should still be considered eligible for self compaction. An early return statement was missing a check for this condition. Add it so that tombstones will be properly removed for a segment eligible for removal. Also adjusts a `vassert()` to account for this case. (cherry picked from commit 1f5f363)
andrwng
approved these changes
Dec 9, 2024
Done, thanks |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/59506#0193ada6-70d5-41d7-b94a-9e0ea7483f46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of commit 1f5f363.
Segments that may have tombstone records in them should still be considered eligible for self compaction.
An early return statement was missing a check for this condition. Add it so that tombstones will be properly removed for a segment eligible for removal.
Also adjusts a
vassert()to account for this case.Backports Required
Release Notes
Bug Fixes