[v23.3.x] gha: use oidc #23452
Merged
[v23.3.x] gha: use oidc #23452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0020a8a)
(cherry picked from commit 78d6a61)
(cherry picked from commit 0ad5e1c)
(cherry picked from commit 58cf73d)
(cherry picked from commit eb7121b)
(cherry picked from commit 7c9526e)
These expressions will not guard against anything with the workflow only triggering on tags with "v*". (cherry picked from commit f504034)
(cherry picked from commit 951682a)
andrewhsu
force-pushed
the
PESDLC-1736-v23.3.x-gh-oidc
branch
2 times, most recently
from
c3720c7 to
42bf760
Compare
andrewhsu
requested review from
hobbseltoff,
ivotron and
WillemKauf
and removed request for
a team and
hobbseltoff
|
@WillemKauf it seems that even if i backport commits from #23036 #23045 to this |
|
Yeah looks like the transform SDK has issues with the bumped Rust version. I'm not sure if the transform SDK can have its Rust version easily bumped and backported as well, or if you would prefer to just not backport either of those Rust related commits. For simplicity, I don't think it's a big deal to leave them out. |
andrewhsu
force-pushed
the
PESDLC-1736-v23.3.x-gh-oidc
branch
from
327e892 to
dadc289
Compare
i dropped those commits. ready for review. |
ivotron
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23423
Fixes #23437
jira: PESDLC-1736
This PR updates the workflow files triggered from the
v23.3.xbranch that use actionaws-actions/configure-aws-credentialsto run with OIDC tokens.There were many conflicts when I first attempted to cherry-pick all the commits from PR #23423 that were unrelated to OIDC tokens and/or changed workflow files that wouldn't run on this
v23.3.xbranch, so I only cherry-picked a subset of the commits that are needed. This reduced the changeset to just these files:cloud-installpack-bk-trigger.ymlpromote.ymlrelease-rp-storage-tool.ymlBackports Required
Release Notes