-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-6860 SR: Wire up support for ?verbose
compatibility checks
#22877
Conversation
Signed-off-by: Oren Leiman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. leaving approval flag off b/c I wrote some of this code.
7225b94
to
80f2482
Compare
80f2482
to
364ad1d
Compare
364ad1d
to
ff0c34d
Compare
Force-push: more code review feedback (conditionally rendering messages, changing transitional compat check order) |
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53058#01915c21-9cf6-445e-99f4-dcf844eeda12 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53133#01916afe-9ebc-489d-b506-0fcd0ebd72c8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
This matches the reference implementation and provides a more useful output because the users likely prefer comparing the new schema against the most recent incompatible schema.
ff0c34d
to
dcf281c
Compare
Force-push: address rpk feedback + fix failing bazel build |
@documentation @gene-redpanda @Deflaimun Let me know if you disagree but I believe your review won't be necessary for this PR because we are only extending the output of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rpk changes LGTM, thanks!
/backport v24.2.x |
/backport v24.1.x |
/backport v23.3.x |
Failed to create a backport PR to v24.2.x branch. I tried:
|
Failed to create a backport PR to v24.1.x branch. I tried:
|
Failed to create a backport PR to v23.3.x branch. I tried:
|
@pgellert you're correct. I get tagged on every property and rpk change. When it's code only, and not doc strings, I just skip the PR. |
*/ | ||
class avro_incompatibility { | ||
public: | ||
using Type = avro_incompatibility_type; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercase unless its a template parameter
This implements minimal support for the verbose flag on the compatibility check endpoints in schema registry. It includes rpk support. In redpanda, this introduces reporting more verbose information about the compatibility check performed. Currently only three new lines are reported when there is an incompatibility that show the version plus definition of the schema we are comparing against and the compatibility level being used. With this PR we don't yet support reporting the name of the specific compatibility check that was violated, but we implement much of the wiring to be able to do that in a follow-up PR.
This PR was cherry-picked and then adapted from @oleiman's earlier PR #18332.
Example rpk output on incompatibility:
Fixes https://redpandadata.atlassian.net/browse/CORE-6860
Backports Required
Release Notes
Features