Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to goreleaser v2 #21538

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

update to goreleaser v2 #21538

wants to merge 6 commits into from

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Jul 19, 2024 •
edited
Loading

jira: DEVPROD-1690

goreleaser has deprecated v1 config format and there has not been updates to that major ver since may. this PR updates goreleaser config file to the latest v2 format.

and update goreleaser-action to check the v2 format of the config file

also, cleanup commits for CODEOWNERS

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

@andrewhsu andrewhsu force-pushed the PESDLC-1690-goreleaser-v2 branch from 2c560a9 to fc4dc3d Compare July 19, 2024 22:32
@andrewhsu andrewhsu marked this pull request as ready for review July 19, 2024 23:00
@andrewhsu
Copy link
Member Author

goreleaser v2 check is green, ready for review

gene-redpanda
gene-redpanda previously approved these changes Jul 19, 2024
View reviewed changes
jackietung-redpanda
jackietung-redpanda reviewed Jul 20, 2024
View reviewed changes
.github/workflows/lint-golang.yml Outdated
with:
version: v1.24.0
args: check src/go/.goreleaser.yaml
distribution: goreleaser-pro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's moderately interesting that config check operation running with goreleaser pro binary is running fine without GORELEASER_KEY!

@jackietung-redpanda
Copy link
Contributor

We should touchbase on Monday to confirm we want to roll with goreleaser v2 for everything, right now.

@andrewhsu
Copy link
Member Author

converting this PR to draft mode to merge this change in later after the dust settles. there already exists a PR to downgrade connect to use goreleaser v1: redpanda-data/connect#2727

@andrewhsu andrewhsu marked this pull request as draft July 23, 2024 14:33
@andrewhsu andrewhsu force-pushed the PESDLC-1690-goreleaser-v2 branch 3 times, most recently from d7f4911 to 9b6314a Compare October 15, 2024 03:12
@andrewhsu andrewhsu force-pushed the PESDLC-1690-goreleaser-v2 branch from 9b6314a to 8d1fc85 Compare October 28, 2024 21:51
@andrewhsu andrewhsu requested a review from ivotron October 28, 2024 22:07
@andrewhsu andrewhsu changed the title gha: update workflow to goreleaser v2 update to goreleaser v2 Oct 28, 2024
@andrewhsu andrewhsu marked this pull request as ready for review October 28, 2024 23:00
ivotron
ivotron previously approved these changes Oct 29, 2024
View reviewed changes
@ivotron ivotron self-requested a review October 29, 2024 00:38
@ivotron ivotron dismissed their stale review October 29, 2024 00:39

i missed the status check

@ivotron
Copy link
Member

ivotron commented Oct 29, 2024 •
edited
Loading

@andrewhsu opened https://github.com/redpanda-data/vtools/pull/3262 to have changes to .goreleaser.yaml trigger rpk checks. After that merges, re-running the build for this PR should now pickup the changes and build/test rpk accordingly

@andrewhsu andrewhsu force-pushed the PESDLC-1690-goreleaser-v2 branch from 8d1fc85 to 4e46d98 Compare October 30, 2024 20:50
@andrewhsu andrewhsu enabled auto-merge October 30, 2024 20:51
@andrewhsu andrewhsu force-pushed the PESDLC-1690-goreleaser-v2 branch 2 times, most recently from 1e5c571 to 719ec20 Compare November 1, 2024 23:33
@andrewhsu andrewhsu marked this pull request as draft November 6, 2024 18:16
auto-merge was automatically disabled November 6, 2024 18:16

Pull request was converted to draft

@andrewhsu
codeowners: rm dswang
fe0d001
@andrewhsu
codeowners: rm file .goreleaser_rpk_connect.yaml
94530c6 
Because it does not exist anymore.
@andrewhsu
gha: cleanup lint-golang
e78c211
@andrewhsu
gha: update to goreleaser/goreleaser-action@v6
391a10e
@andrewhsu
goreleaser: update config to v2 format
2e42ee5
@andrewhsu
goreleaser: move quill log files out of dist dir
b11be85 
Because dist dir will be cleaned by goreleaser. Addresses error:
```
error=dist is not empty, remove it before running goreleaser or use the
--clean flag
```
@andrewhsu andrewhsu force-pushed the PESDLC-1690-goreleaser-v2 branch from 719ec20 to b11be85 Compare January 8, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackietung-redpanda jackietung-redpanda jackietung-redpanda approved these changes

@gene-redpanda gene-redpanda gene-redpanda left review comments

@Jeffail Jeffail Awaiting requested review from Jeffail

@twmb twmb Awaiting requested review from twmb

@r-vasquez r-vasquez Awaiting requested review from r-vasquez r-vasquez is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun

@ivotron ivotron Awaiting requested review from ivotron

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewhsu @jackietung-redpanda @ivotron @gene-redpanda