[v23.2.x] k/group: recover leader epoch on leader change #17397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerifiableConsumer is KIP-320 compliant now. At least to the degree the java kafka client is. This will facilitates testing of the redpanda implementation of KIP-320 in group recovery (redpanda-data#17260) and data loss handling when write caching is enabled. (cherry picked from commit 9316309)
This tests consumer group commits. The test also shows a bug in which leader_offset is reset after cluster restart. This is fixed in a subsequent commit. (cherry picked from commit e1a3e65)
This was discovered while testing write caching feature. After leadership change or node restart we would reply with default field value `-2147483648` which breaks the KIP-320 logic. `check_leader_epoch` in redpanda treats negative epoch values as "not set" and, I believe, franz-go behaves the same. As result, KIP-320 fencing is not being applied and the client ends up with `OFFSET_OUT_OF_RANGE` error. (cherry picked from commit 501b9d3)
piyushredpanda
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17260