[v23.2.x] cluster: invoke config_frontend methods on controller shard #17211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various places in the code were calling do_patch directly without regard to the requirement that do_patch has to be called on the controller shard. This caused a fixture test to fail because it tried to invoke do_patch on all shards and this violates the assertion in do_patch of config_frontend.cc, causing it to fail with the error message "Must be called on version_shard". This fixes it by changing config_fronter::patch() to invoke do_patch on the controller shard, and moving all calls of do_patch to call patch instead. (cherry picked from commit b7202f1)
Just like patch, we also have to call do_set_next_version on the same shard because config_frontend::set_next_version might be called from a background fiber. (cherry picked from commit ed04fc3)
pgellert
requested review from
BenPope,
oleiman,
graphcareful and
michael-redpanda
michael-redpanda
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17088