Skip to content

Commit

Permalink
Merge pull request #24386 from WillemKauf/polaris_start_fix
Browse files Browse the repository at this point in the history
[CORE-8338] `rptest`: add `timeout` to `_polaris_ready()` check
  • Loading branch information
WillemKauf authored Dec 2, 2024
2 parents 2417491 + a4f182d commit ffed0cf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tests/rptest/services/polaris_catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def _polaris_ready():
f"Querying polaris healthcheck on http://{node.account.hostname}:8182/healthcheck"
)
r = requests.get(
f"http://{node.account.hostname}:8182/healthcheck")
f"http://{node.account.hostname}:8182/healthcheck", timeout=10)

self.logger.info(
f"health check result status code: {r.status_code}")
Expand Down
4 changes: 2 additions & 2 deletions tests/rptest/tests/polaris_catalog_smoke_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def __init__(self, test_ctx, *args, **kwargs):
def setUp(self):
pass

def _start_redpanad(self, catalog_prefix, client_id, client_secret,
def _start_redpanda(self, catalog_prefix, client_id, client_secret,
with_tls):
self.redpanda._extra_rp_conf.update({
"iceberg_enabled":
Expand Down Expand Up @@ -204,7 +204,7 @@ def test_connecting_to_catalog(self, cloud_storage_type, with_tls):
principal_name = "test-user"
credentials = self._initialize_catalog(catalog_name, principal_name)

self._start_redpanad(catalog_prefix=catalog_name,
self._start_redpanda(catalog_prefix=catalog_name,
client_id=credentials.client_id,
client_secret=credentials.client_secret,
with_tls=with_tls)
Expand Down

0 comments on commit ffed0cf

Please sign in to comment.