Skip to content

Commit

Permalink
feature_table: remove unused feature flags
Browse files Browse the repository at this point in the history
  • Loading branch information
@bashtanov
bashtanov committed Nov 7, 2024
1 parent 257dd07 commit b763ec7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 126 deletions.
28 changes: 0 additions & 28 deletions src/v/features/feature_table.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,40 +36,12 @@ namespace features {

std::string_view to_string_view(feature f) {
switch (f) {
case feature::serde_raft_0:
return "serde_raft_0";
case feature::license:
return "license";
case feature::raft_improved_configuration:
return "raft_improved_configuration";
case feature::transaction_ga:
return "transaction_ga";
case feature::raftless_node_status:
return "raftless_node_status";
case feature::rpc_v2_by_default:
return "rpc_v2_by_default";
case feature::cloud_retention:
return "cloud_retention";
case feature::node_id_assignment:
return "node_id_assignment";
case feature::replication_factor_change:
return "replication_factor_change";
case feature::ephemeral_secrets:
return "ephemeral_secrets";
case feature::seeds_driven_bootstrap_capable:
return "seeds_driven_bootstrap_capable";
case feature::tm_stm_cache:
return "tm_stm_cache";
case feature::kafka_gssapi:
return "kafka_gssapi";
case feature::partition_move_revert_cancel:
return "partition_move_cancel_revert";
case feature::node_isolation:
return "node_isolation";
case feature::group_offset_retention:
return "group_offset_retention";
case feature::rpc_transport_unknown_errc:
return "rpc_transport_unknown_errc";
case feature::membership_change_controller_cmds:
return "membership_change_controller_cmds";
case feature::controller_snapshots:
Expand Down
98 changes: 0 additions & 98 deletions src/v/features/feature_table.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,9 @@ struct feature_table_snapshot;
/// only used at runtime. Therefore it is safe to re-use an integer that
/// has been made available by another feature being retired.
enum class feature : std::uint64_t {
serde_raft_0 = 1ULL << 5U,
license = 1ULL << 6U,
raft_improved_configuration = 1ULL << 7U,
transaction_ga = 1ULL << 8U,
raftless_node_status = 1ULL << 9U,
rpc_v2_by_default = 1ULL << 10U,
cloud_retention = 1ULL << 11U,
node_id_assignment = 1ULL << 12U,
replication_factor_change = 1ULL << 13U,
ephemeral_secrets = 1ULL << 14U,
seeds_driven_bootstrap_capable = 1ULL << 15U,
tm_stm_cache = 1ULL << 16U,
kafka_gssapi = 1ULL << 17U,
partition_move_revert_cancel = 1ULL << 18U,
node_isolation = 1ULL << 19U,
group_offset_retention = 1ULL << 20U,
rpc_transport_unknown_errc = 1ULL << 21U,
membership_change_controller_cmds = 1ULL << 22U,
controller_snapshots = 1ULL << 23U,
cloud_storage_manifest_format_v2 = 1ULL << 24U,
Expand Down Expand Up @@ -220,90 +206,12 @@ struct feature_spec {
};

inline constexpr std::array feature_schema{
feature_spec{
release_version::v22_2_1,
"serde_raft_0",
feature::serde_raft_0,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_2_1,
"license",
feature::license,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_2_1,
"raft_improved_configuration",
feature::raft_improved_configuration,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_2_6,
"transaction_ga",
feature::transaction_ga,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_3_1,
"raftless_node_status",
feature::raftless_node_status,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_3_1,
"rpc_v2_by_default",
feature::rpc_v2_by_default,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_3_1,
"cloud_retention",
feature::cloud_retention,
feature_spec::available_policy::always,
feature_spec::prepare_policy::requires_migration},
feature_spec{
release_version::v22_3_1,
"node_id_assignment",
feature::node_id_assignment,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_3_1,
"replication_factor_change",
feature::replication_factor_change,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_3_1,
"ephemeral_secrets",
feature::ephemeral_secrets,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_3_1,
"seeds_driven_bootstrap_capable",
feature::seeds_driven_bootstrap_capable,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v22_3_6,
"tm_stm_cache",
feature::tm_stm_cache,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v23_1_1,
"kafka_gssapi",
feature::kafka_gssapi,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v23_1_1,
"partition_move_revert_cancel",
feature::partition_move_revert_cancel,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v23_1_1,
"node_isolation",
Expand All @@ -316,12 +224,6 @@ inline constexpr std::array feature_schema{
feature::group_offset_retention,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v23_1_1,
"rpc_transport_unknown_errc",
feature::rpc_transport_unknown_errc,
feature_spec::available_policy::always,
feature_spec::prepare_policy::always},
feature_spec{
release_version::v23_2_1,
"membership_change_controller_cmds",
Expand Down

0 comments on commit b763ec7

Please sign in to comment.