Merge pull request #16513 from andijcr/feat/config_millis_lowerbound

config/configuration: bounded_property log_segment_ms_min/max
redpanda-data · Feb 24, 2024 · 6c059e4 · 6c059e4
2 parents 7a3b3d5 + 69d1a67
commit 6c059e4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/v/config/configuration.cc b/src/v/config/configuration.cc
@@ -104,7 +104,8 @@ configuration::configuration()
       {.needs_restart = needs_restart::no,
        .example = "600000",
        .visibility = visibility::tunable},
-      10min)
+      10min,
+      {.min = 0ms})
   , log_segment_ms_max(
       *this,
       "log_segment_ms_max",
@@ -113,7 +114,8 @@ configuration::configuration()
       {.needs_restart = needs_restart::no,
        .example = "31536000000",
        .visibility = visibility::tunable},
-      24h * 365)
+      24h * 365,
+      {.min = 0ms})
   , rpc_server_listen_backlog(
       *this,
       "rpc_server_listen_backlog",

diff --git a/src/v/config/configuration.h b/src/v/config/configuration.h
@@ -52,8 +52,8 @@ struct configuration final : public config_store {
     bounded_property<uint64_t> compacted_log_segment_size;
     property<std::chrono::milliseconds> readers_cache_eviction_timeout_ms;
     bounded_property<std::optional<std::chrono::milliseconds>> log_segment_ms;
-    property<std::chrono::milliseconds> log_segment_ms_min;
-    property<std::chrono::milliseconds> log_segment_ms_max;
+    bounded_property<std::chrono::milliseconds> log_segment_ms_min;
+    bounded_property<std::chrono::milliseconds> log_segment_ms_max;
 
     // Network
     bounded_property<std::optional<int>> rpc_server_listen_backlog;