Skip to content

Commit

Permalink
rptest: produce more data in FullDiskReclaimTest to trigger gc condit…
Browse files Browse the repository at this point in the history
…ions

For reasons not well understood each partition needs to have at least 2
segments for eviction to be triggered. We have tried to change this
condition in #22686 but
had to revert it in
#22995.

For now, produce more data to increase the chance of each partition
having at least 2 segments worth of data.

(cherry picked from commit 79d706e)
  • Loading branch information
nvartolomei authored and vbotbuildovich committed Sep 26, 2024
1 parent fb88955 commit 2b33a1a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/v/storage/disk_log_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,12 @@ disk_log_impl::request_eviction_until_offset(model::offset max_offset) {
_eviction_monitor.reset();

co_return model::next_offset(max_offset);
} else {
vlog(
gclog.debug,
"[{}] no segments to evict up to {} offset; skipping eviction",
config().ntp(),
max_offset);
}

co_return _start_offset;
Expand Down
2 changes: 1 addition & 1 deletion tests/rptest/tests/full_disk_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def observed_data_size(pred):
return pred(observed_total)

# write around 30 megabytes into the topic
produce_total_bytes(self.redpanda, self.topic, nbytes(30))
produce_total_bytes(self.redpanda, self.topic, nbytes(100))

# wait until all that data shows up. add some fuzz factor to avoid
# timeouts due to placement skew or other such issues.
Expand Down

0 comments on commit 2b33a1a

Please sign in to comment.