-
Notifications
You must be signed in to change notification settings - Fork 597
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #23924 from gene-redpanda/list-mountable
List mountable
- Loading branch information
Showing
8 changed files
with
94 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| package storage | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "io" | ||
| "os" | ||
|
|
||
| "github.com/redpanda-data/common-go/rpadmin" | ||
| "github.com/redpanda-data/redpanda/src/go/rpk/pkg/adminapi" | ||
| "github.com/redpanda-data/redpanda/src/go/rpk/pkg/config" | ||
| "github.com/redpanda-data/redpanda/src/go/rpk/pkg/out" | ||
| "github.com/spf13/afero" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func newListMountable(fs afero.Fs, p *config.Params) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "list-mountable", | ||
| Short: "List mountable topics from object storage", | ||
| Long: `List topics that are available to mount from object storage. | ||
| This command displays topics that exist in object storage and can be mounted | ||
| to your Redpanda cluster. Each topic includes its location in object storage | ||
| and namespace information if applicable.`, | ||
| Example: ` | ||
| List all mountable topics: | ||
| rpk cluster storage list-mountable | ||
| `, | ||
| Args: cobra.NoArgs, | ||
| Run: func(cmd *cobra.Command, _ []string) { | ||
| f := p.Formatter | ||
| if h, ok := f.Help([]mountableTopicState{}); ok { | ||
| out.Exit(h) | ||
| } | ||
|
|
||
| pf, err := p.LoadVirtualProfile(fs) | ||
| out.MaybeDie(err, "rpk unable to load config: %v", err) | ||
| config.CheckExitCloudAdmin(pf) | ||
| adm, err := adminapi.NewClient(cmd.Context(), fs, pf) | ||
| out.MaybeDie(err, "unable to initialize admin client: %v", err) | ||
|
|
||
| response, err := adm.ListMountableTopics(cmd.Context()) | ||
| out.MaybeDie(err, "unable to list mountable topics: %v", err) | ||
| printDetailedListMountable(p.Formatter, rpadminMountableTopicsToMountableTopicState(response.Topics), os.Stdout) | ||
| }, | ||
| } | ||
| p.InstallFormatFlag(cmd) | ||
| return cmd | ||
| } | ||
|
|
||
| func printDetailedListMountable(f config.OutFormatter, d []mountableTopicState, w io.Writer) { | ||
| if isText, _, t, err := f.Format(d); !isText { | ||
| out.MaybeDie(err, "unable to print in the requested format %q: %v", f.Kind, err) | ||
| fmt.Fprintln(w, t) | ||
| return | ||
| } | ||
| tw := out.NewTableTo(w, "Topic", "Namespace", "Location") | ||
| defer tw.Flush() | ||
| for _, m := range d { | ||
| namespace := "kafka" // default namespace | ||
| if m.Namespace != nil { | ||
| namespace = *m.Namespace | ||
| } | ||
| tw.Print(m.Topic, namespace, m.TopicLocation) | ||
| } | ||
| } | ||
|
|
||
| type mountableTopicState struct { | ||
| Topic string `json:"topic" yaml:"topic"` | ||
| Namespace *string `json:"namespace,omitempty" yaml:"namespace,omitempty"` | ||
| TopicLocation string `json:"topic_location" yaml:"topic_location"` | ||
| } | ||
|
|
||
| func rpadminMountableTopicsToMountableTopicState(in []rpadmin.MountableTopic) []mountableTopicState { | ||
| resp := make([]mountableTopicState, 0, len(in)) | ||
| for _, entry := range in { | ||
| state := mountableTopicState{ | ||
| Topic: entry.Topic, | ||
| Namespace: entry.Namespace, | ||
| TopicLocation: entry.TopicLocation, | ||
| } | ||
| resp = append(resp, state) | ||
| } | ||
| return resp | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters