fix: merge camelCase properties from config file correctly with environment variables #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
weeco
reviewed
Feb 10, 2024
Comment on lines
+64
to
+67
| err := k.Load(file.Provider(configFilepath), yaml.Parser(), koanf.WithMergeFunc(func(src, dest map[string]interface{}) error { | ||
| dest = src | ||
| return nil | ||
| })) |
There was a problem hiding this comment.
This is only called if you actually provide a YAML config file and therefore this does not fix the referenced issue
There was a problem hiding this comment.
You are right. Thank you for the hint. I missed the fact that no config file was referenced in the linked issue. I just had a similar problem where I wanted to overwrite some values from the config file with individual environment variables. Should I create a new issue for this?
There was a problem hiding this comment.
You can add that to the issue, but the fix I proposed there would fix this as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to get environment overrides working for camelCase config keys.
closes #179