Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #238

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Update README.md #238

merged 2 commits into from
Jun 7, 2024

Conversation

amjedidiah
Copy link
Contributor

Other table column titles match their respective bullet point title. It would be nice for phonetic to read phonetic in the bullet point and not matcher

Other table column titles match their respective bullet point title.
It would be nice for `phonetic` to read `phonetic` in the bullet point and not `matcher`
@guyroyse
Copy link
Contributor

guyroyse commented Jun 7, 2024

This is actually the other way around in the code. So the header in the table is incorrect, not the text under it.

@guyroyse
Copy link
Contributor

guyroyse commented Jun 7, 2024

To be fair, I think it would be better if the field was named phoneticMatcher but that would be a breaking change.

@amjedidiah
Copy link
Contributor Author

Oooh
Okay, noted.

@amjedidiah
Copy link
Contributor Author

Do I revert changes and close this or do I make the change to the incorrect one?

@amjedidiah
Copy link
Contributor Author

Pushing for coherency

@amjedidiah
Copy link
Contributor Author

Redis is pretty cool as well
Learning it cos I have a project where its use seems reasonable.
Using it together with MongoDB

@guyroyse
Copy link
Contributor

guyroyse commented Jun 7, 2024

Just go ahead and update this PR and then I can merge it in.

Fixed concurrency as guided by Guy Royse
@amjedidiah
Copy link
Contributor Author

I'm away from my laptop
But I would have loved to share my planning document so you see.

It's an app that'll have contests between users.
So there's a need to show in relatime contests on both devices in sync and send and receive events as fast as possible at a reasonable cost

@amjedidiah
Copy link
Contributor Author

I've made the change also

@guyroyse guyroyse merged commit 0c38871 into redis:main Jun 7, 2024
2 checks passed
@guyroyse
Copy link
Contributor

guyroyse commented Jun 7, 2024

I'm away from my laptop But I would have loved to share my planning document so you see.

It's an app that'll have contests between users. So there's a need to show in relatime contests on both devices in sync and send and receive events as fast as possible at a reasonable cost

Sounds like a good fit for Redis, probably including things beyond what Redis OM provides. Unfortunately, I get a lot of requests like this and don't have a lot of time to look at them. However, you might find some folks on our Discord server that would be interested in your project. It's at discord.gg/redis.

@amjedidiah
Copy link
Contributor Author

amjedidiah commented Jun 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants