Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): validate that ConfigSet and ConfigGet work with Modules #3258

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(tests): validate that ConfigSet and ConfigGet work with Modules #3258

wants to merge 3 commits into from
+274 −34

Conversation

ndyakov
Copy link
Collaborator

@ndyakov ndyakov commented Jan 31, 2025 •
edited
Loading

  • Add deprecation warnings
  • Test config set and config get for module keys
  • Test config set search-default-dialect and then ft.config get default_dialect
  • Found issue with Resp3 parsing of ft.config get, resolved it. Since ft.config will be dropped, it was not justified to improve the solution any further.
  • added additional tests, including negative (read only and wrong values)

@ndyakov ndyakov changed the title Ndyakov/unify config redis 8 feat(tests): validate that ConfigSet and ConfigGet work with Modules Jan 31, 2025
@ndyakov ndyakov force-pushed the ndyakov/unify-config-redis-8 branch from fd9d9c4 to 6cf6468 Compare January 31, 2025 19:25
@ndyakov ndyakov requested a review from vladvildanov February 1, 2025 01:06
@ndyakov ndyakov marked this pull request as ready for review February 1, 2025 01:06
@ndyakov ndyakov force-pushed the ndyakov/unify-config-redis-8 branch 2 times, most recently from 8b06411 to 7a54196 Compare February 1, 2025 01:26
@ndyakov ndyakov force-pushed the ndyakov/unify-config-redis-8 branch from 7a54196 to 201a570 Compare February 1, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov Awaiting requested review from vladvildanov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndyakov