Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#96 - Added printable list also into archive. #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jan 18, 2017

Overview

  • Added printable list into archive
    • Created new printable list template make it more DRY (still not ideal, but definitely better).
    • Column View checkboxes are now generated and not hardcoded.
  • Created new tagLib DateRangePicker responsible for picking date range.
    • Added JQueryUI dependency to make it possible.
  • PrintableList functions in Topic and Thesis now require permissions to view.
    • I had to rename them to just printable, because I wasn't able to secured anything that contains "list".
  • Added dateFinished column into thesis to indicate when thesis was finished.
    • dateFinished will be automatically set when setting thesis to finished.
    • Old theses where this field is missing won't have any dateFinished.

Changes in files

BootStrap.groovy

  • Small changes to development entities.

TestBootStrap.groovy

  • Updated test configuration.

BuildConfig.groovy

  • Added JQueryUI.

ThesisController.groovy

  • Added new printable method.
  • Added new clause which checks if status was newly set to Finished and if so then adds dateFinished.

TopicController.groovy

  • Renamed printableList to just printable.
  • Updated printable function to keep up with changes in printable template.

Thesis.groovy

  • Added new nullable column dateFinished.

I18n files

  • Both files now have the exact number of lines.

FIlterService.groovy

  • Added support for filtering date range.
    • variable/from - will be split into variable and fromDate and will be evaluated as starting date.
    • variable/to - will be split into variable and toDate and will be evaluated as ending date.

ThesisService.groovy

  • Save function declaration now has correct number of gaps.

DateRangePickerTagLib.groovy

  • New tagLib which generates date range input fields.

_dateRangePicker.gsp

  • View for DateRangePicker tagLib.

printable.gsp

  • New printable template which contains number of pageProperties for easier implementation of new printables.

thesis/list.gsp

  • Added manage panel into thesis which contains hyperlink to printable.

thesis/printable.gsp

  • Actual implementation of printable template.

thesis/show.gsp

  • DateFinished is now shown in the sidebar if set.

topic/_topicList.gsp

  • Changed link destination and i18n property names.

topic/printable.gsp

  • Reworked to fit printable template.

ThesisControllerIntegrationSpec.groovy

  • Tests almost all functions that have any fail state in ThesisController.
    • I wasn't able to test successful update(), which is probably most logic heavy function in whole controller and was changed in this update, because bindData method throws UnsupportedOperationException when tested and I couldn't figure out why.

UniversityControllerIntegrationSpec.groovy

  • Minor changes to imports.

- Made printable list template more DRY (still not ideal, but definitely better)
 - Many things moved into printable layout to avoid code repetition
- Added dateFinished column into thesis to indicate when thesis was finished
 - dateFinished will be automatically set when setting thesis to finished
 - Old theses where this field was missing won't have any dateFinished
- Added printable list into archive
 - Based on the new printable template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant