Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove push to Test PyPI registry #145

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Remove push to Test PyPI registry #145

merged 1 commit into from
Oct 15, 2024

Conversation

x00Pavel
Copy link
Member

No description provided.

@x00Pavel x00Pavel self-assigned this Oct 15, 2024
GeorgePantelakis
GeorgePantelakis approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@GeorgePantelakis GeorgePantelakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@x00Pavel
Copy link
Member Author

@GeorgePantelakis is it expected that two tests are failed? please, check the status note in this PR

@GeorgePantelakis
Copy link
Collaborator

@x00Pavel
if you are talking about Unit tests yes, because there wasn't any update on the tests to reflect the new changes. I have in my todo list to recreate all the Unit tests to some more meaningful tests.
If you are not talking about that I don't see some other failures.

@x00Pavel
Copy link
Member Author

@GeorgePantelakis ok, thanks

@x00Pavel x00Pavel merged commit 67004e0 into master Oct 15, 2024
4 of 6 checks passed
@x00Pavel x00Pavel deleted the fix-gh-action-pypi-publish branch October 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgePantelakis GeorgePantelakis GeorgePantelakis approved these changes

@Jakuje Jakuje Awaiting requested review from Jakuje

Assignees

@x00Pavel x00Pavel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x00Pavel @GeorgePantelakis