Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to distro package for os recognition. #138

Merged

Conversation

GeorgePantelakis
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this also in the SCAutolib/models/file.py as discussed in https://github.com/redhat-qe-security/SCAutolib/pull/137/files#r1624433165

SCAutolib/controller.py Show resolved Hide resolved
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the flake complains, but otherwise lgtm

SCAutolib/controller.py Show resolved Hide resolved
@GeorgePantelakis
Copy link
Collaborator Author

@Jakuje flake is OK now

Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GeorgePantelakis GeorgePantelakis merged commit da0f43b into redhat-qe-security:master Jun 5, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants