-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly support vm.dirty_(bytes|ratio) and vm.dirty_background_(bytes|ratio) #688
base: master
Are you sure you want to change the base?
Conversation
2545607
to
4c724c2
Compare
Thank you! Planning to take a look today, tomorrow at the latest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, Pavol. I've tested the code and it resolves https://issues.redhat.com/browse/RHEL-58820. I've also checked the changes in TuneD profiles. They seem fine. Also had a quick look at the code and apart from a minor nit with the style (which is a matter of opinion anyway) it looks fine to me.
And for dirty_background_(bytes|ratio). These parameters interact with each other; it is therefore not sufficient to configure them via the sysctl plugin. For more details, see https://docs.kernel.org/admin-guide/sysctl/vm.html#dirty-bytes. Resolves: RHEL-58820
4c724c2
to
c603d8c
Compare
Thank you for the changes. I believe the whole PR is cleaner this way. I've also retested the scenario in RHEL-58820. |
The options interact within these two pairs: when
dirty_bytes
is set,dirty_ratio
is automatically set to 0 and vice versa. Rollback thus does not work out of the box when setting these options via the sysctl plugin.This PR adds explicit support for the options into the VM plugin: the new custom commands check whether the value set in the profile is permitted and the rollback is adjusted: the option that was not 0 before the profile switch is reverted.
@jmencak, feel free to test this.