Readd validate inventory and display plan, remove os_images and release_images and set default installer to agent based. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nocturnalastro
changed the title
nocturnalastro
force-pushed
the
readd_validate_inventory
branch
from
bec54ea to
8c5e110
Compare
Merged
nocturnalastro
force-pushed
the
readd_validate_inventory
branch
3 times, most recently
from
5af284e to
54966a9
Compare
nocturnalastro
force-pushed
the
readd_validate_inventory
branch
from
54966a9 to
c02ef69
Compare
arjuhe
approved these changes
Mar 26, 2024
hack/pip-requirments.txt
Outdated
There was a problem hiding this comment.
Just add these direct to the requirements.txt. It would make the install process a little easier.
There was a problem hiding this comment.
I have removed the requirements file and instead I've just put the instructions in the README
nocturnalastro
force-pushed
the
readd_validate_inventory
branch
from
c02ef69 to
97e9139
Compare
arjuhe
requested changes
Mar 28, 2024
| @@ -595,17 +627,6 @@ The basic network configuration of the inventory for the fully bare metal deploy | |||
| bmc_address: 172.30.10.7 | |||
| # ... | |||
| ``` | |||
| ## Additional Partition Deployment | |||
|
|
|||
| For OCP 4.8+ deployments you can set partitions if required on the nodes. You do this by adding the snippet below to the node definition. Please ensure you provide the correct label and size(MiB) for the additional partitions you want to create. The device can either be the drive in which RHCOS image needs to be installed or it can be any additional drive on the node that requires partitioning. In the case that the device is equal to the host's `installation_disk_path` then a partition will be added defined by `disks_rhcos_root`. All additional partitions must be added under `extra_partitions` key as per the example below. | |||
There was a problem hiding this comment.
One sentance per line here.
docs/inventory.md
Outdated
| @@ -651,7 +672,7 @@ You must have these services when using PXE deployment | |||
| vendor: pxe | |||
| bmc_address: "nfvpe-21.oot.lab.eng.bos.redhat.com" | |||
| bmc_port: 8082 | |||
|
|
|||
| ``` | |||
| > **Note**: that the BMCs of the nodes in the cluster must be routable from the bastion host and the HTTP Store must be routable from the BMCs | |||
docs/inventory.md
Outdated
|
|
||
| ## Day 2 nodes | ||
|
|
||
| Day 2 nodes are added to an existing cluster. The reason why the installation of day 2 nodes is built into the main path of our automation, is that for assisted installer day 2 nodes can be on a different L2 network which the main flow does not allow. |
There was a problem hiding this comment.
sentence per line
[edited to correct spelling]
docs/inventory.md
Outdated
|
|
||
| ## Additional Partition Deployment | ||
|
|
||
| For OCP 4.8+ deployments you can set partitions if required on the nodes. You do this by adding the snippet below to the node definition. Please ensure you provide the correct label and size(MiB) for the additional partitions you want to create. The device can either be the drive in which RHCOS image needs to be installed or it can be any additional drive on the node that requires partitioning. In the case that the device is equal to the host's `installation_disk_path` then a partition will be added defined by `disks_rhcos_root`. All additional partitions must be added under `extra_partitions` key as per the example below. |
There was a problem hiding this comment.
sentence per line
[edited to correct spelling]
hack/README.md
Outdated
| pip install semver beautifulsoup4 | ||
| ``` | ||
|
|
||
| ## Useage |
As we don't host the vendor role anymore it doesn't make sense to have this test
nocturnalastro
force-pushed
the
readd_validate_inventory
branch
from
af5753d to
4a5b8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.